Ignore:
Timestamp:
Feb 21, 2020 1:32:52 PM (3 years ago)
Author:
srkline
Message:

VSANS: changes here are simply cleaning up comments and TODO items

SANS: added a contextual menu simialr to VSANS so that RAW, MSK, DIV can be directly loaded from the FileCatalog?, in the sam way that they are in VSANS

File:
1 edited

Legend:

Unmodified
Added
Removed
  • sans/Dev/trunk/NCNR_User_Procedures/Reduction/VSANS/V_DetectorCorrections.ipf

    r1239 r1240  
    167167        // the distance perpendicular to the tube is n*(8.4mm) per tube index 
    168168         
    169         // TODO 
    170         // -- GAP IS HARD-WIRED as constant values  
     169        // DONE 
     170        // -- GAP was hard-wired, but in 2018 proper values for all 4 gaps were measured 
     171        // and added to the file header for each detector panel. there is now a read from the  
     172        // header to get the gap value  
    171173        Variable offset,gap 
    172174 
    173 // kPanelTouchingGap is in mm    
    174 // the gap is split equally between the panel pairs 
    175 // (DONE) -- replace all of this with V_getDet_panel_gap(fname,detStr) once it is added to the file 
    176  
    177175        gap = V_getDet_panel_gap(fname,detStr) 
    178176 
    179 // TODO: 
    180 // -- once the gap fields have been verified, this check can be removed 
     177// DONE: 
     178// -- in case of error, V_getDet_panel_gap() will return -999999 
    181179// -- it should only apply to data pre-2018 when the field did not exist in the file 
    182 // -- any VSANS data from 2018+ should read gap from the file. 
     180// -- any VSANS data from 2018+ should read gap from the file and bypass the if() 
    183181 
    184182        if(gap < -100)          //-999999 returned if field is missing from file 
     
    446444        Variable gap  
    447445 
    448 // kPanelTouchingGap is in mm    
    449446// the gap is split equally between the panel pairs 
    450 // TODO -- replace all of this with V_getDet_panel_gap(fname,detStr) once it is added to the file 
    451 // these hard-wired values were determined from 6A and WB beam centers. LR values were exactly the same for 
    452 // both beam considitions (+/- 0.0 mm). FTB was +/- 0.8 mm, MTB +/- 2 mm 
     447// DONE -- replace hard-wired values with V_getDet_panel_gap(fname,detStr) once it is added to the file 
    453448 
    454449        gap = V_getDet_panel_gap(folder,detStr) 
    455450 
    456 // TODO: 
    457 // -- once the gap fields have been verified, this check can be removed 
     451// DONE: 
     452// -- check in case of error, value should be read from header 
    458453// -- it should only apply to data pre-2018 when the field did not exist in the file 
    459454// -- any VSANS data from 2018+ should read gap from the file. 
Note: See TracChangeset for help on using the changeset viewer.